Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "update to log4j 2.17.0 (#8965)" #8969

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Revert "update to log4j 2.17.0 (#8965)" #8969

merged 1 commit into from
Dec 20, 2021

Conversation

lmossman
Copy link
Contributor

@lmossman lmossman commented Dec 20, 2021 •
edited
Loading

This reverts commit c5fc568.

See slack thread: https://airbytehq.slack.com/archives/C0229LM09T4/p1640030021249200

The reason for this is that the bump to log4j 2.17.0 caused the following errors to be repeatedly thrown on server startup:

airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 2021-12-20 19:43:43,235 main ERROR Could not create plugin of type class com.van.logging.log4j2.Log4j2Appender for element Log4j2Appender: java.lang.RuntimeException: Cannot build appender due to errors java.lang.RuntimeException: Cannot build appender due to errors
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at com.van.logging.log4j2.Log4j2AppenderBuilder.build(Log4j2AppenderBuilder.java:142)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at com.van.logging.log4j2.Log4j2AppenderBuilder.build(Log4j2AppenderBuilder.java:25)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.plugins.util.PluginBuilder.build(PluginBuilder.java:122)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.AbstractConfiguration.createPluginObject(AbstractConfiguration.java:1120)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.AbstractConfiguration.createConfiguration(AbstractConfiguration.java:1045)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.appender.routing.RoutingAppender.createAppender(RoutingAppender.java:299)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.appender.routing.RoutingAppender.getControl(RoutingAppender.java:271)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.appender.routing.RoutingAppender.append(RoutingAppender.java:229)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:161)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:134)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:125)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:89)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:542)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:500)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:483)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.LoggerConfig.logParent(LoggerConfig.java:533)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:502)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:483)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:388)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:63)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.Logger.logMessage(Logger.java:153)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.slf4j.Log4jLogger.log(Log4jLogger.java:376)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.util.log.JettyAwareLogger.log(JettyAwareLogger.java:625)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.util.log.JettyAwareLogger.info(JettyAwareLogger.java:314)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.util.log.Slf4jLog.info(Slf4jLog.java:77)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.server.AbstractConnector.doStart(AbstractConnector.java:331)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.server.AbstractNetworkConnector.doStart(AbstractNetworkConnector.java:81)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.server.ServerConnector.doStart(ServerConnector.java:234)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.server.Server.doStart(Server.java:386)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at io.airbyte.server.ServerApp.start(ServerApp.java:109)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at io.airbyte.server.ServerApp.main(ServerApp.java:203)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container Caused by: java.lang.IllegalArgumentException: Cannot create enum from ${sys:S3_LOG_BUCKET_REGION:-} value!
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at com.amazonaws.regions.Regions.fromName(Regions.java:99)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at com.van.logging.aws.S3Configuration.resolveRegion(S3Configuration.java:188)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at com.van.logging.aws.S3Configuration.setRegion(S3Configuration.java:122)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at com.van.logging.log4j2.Log4j2AppenderBuilder.getS3ConfigIfEnabled(Log4j2AppenderBuilder.java:167)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at com.van.logging.log4j2.Log4j2AppenderBuilder.createCachePublisher(Log4j2AppenderBuilder.java:264)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at com.van.logging.log4j2.Log4j2AppenderBuilder.build(Log4j2AppenderBuilder.java:137)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	... 32 more
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 2021-12-20 19:43:43,236 main ERROR Unable to invoke factory method in class com.van.logging.log4j2.Log4j2Appender for element Log4j2Appender: java.lang.IllegalStateException: No factory method found for class com.van.logging.log4j2.Log4j2Appender java.lang.IllegalStateException: No factory method found for class com.van.logging.log4j2.Log4j2Appender
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.plugins.util.PluginBuilder.findFactoryMethod(PluginBuilder.java:236)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.plugins.util.PluginBuilder.build(PluginBuilder.java:134)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.AbstractConfiguration.createPluginObject(AbstractConfiguration.java:1120)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.AbstractConfiguration.createConfiguration(AbstractConfiguration.java:1045)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.appender.routing.RoutingAppender.createAppender(RoutingAppender.java:299)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.appender.routing.RoutingAppender.getControl(RoutingAppender.java:271)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.appender.routing.RoutingAppender.append(RoutingAppender.java:229)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:161)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:134)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:125)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:89)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:542)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:500)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:483)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.LoggerConfig.logParent(LoggerConfig.java:533)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:502)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:483)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:388)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:63)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.log4j.core.Logger.logMessage(Logger.java:153)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.apache.logging.slf4j.Log4jLogger.log(Log4jLogger.java:376)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.util.log.JettyAwareLogger.log(JettyAwareLogger.java:625)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.util.log.JettyAwareLogger.info(JettyAwareLogger.java:314)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.util.log.Slf4jLog.info(Slf4jLog.java:77)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.server.AbstractConnector.doStart(AbstractConnector.java:331)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.server.AbstractNetworkConnector.doStart(AbstractNetworkConnector.java:81)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.server.ServerConnector.doStart(ServerConnector.java:234)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.server.Server.doStart(Server.java:386)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:72)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at io.airbyte.server.ServerApp.start(ServerApp.java:109)
airbyte-server-7b7c989ff9-8f9xs airbyte-server-container 	at io.airbyte.server.ServerApp.main(ServerApp.java:203)

So it likely requires some additional changes to successfully upgrade to version 2.17

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@lmossman lmossman temporarily deployed to more-secrets December 20, 2021 20:07 Inactive
@lmossman lmossman merged commit 63017ea into master Dec 20, 2021
@lmossman lmossman deleted the lmossman/revert-log4j-upgrade branch December 20, 2021 20:18
@lmossman lmossman mentioned this pull request Dec 20, 2021
Merged
40 tasks
This was referenced Dec 20, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lmossman